Re: [v2 PATCH 4/4] timers: logic to enable timer migration.
From: Oleg Nesterov
Date: Thu Mar 05 2009 - 11:27:18 EST
On 03/04, Arun R Bharadwaj wrote:
>
> +++ linux.trees.git/kernel/sched.c
> @@ -4009,6 +4009,11 @@ static struct {
> .load_balancer = ATOMIC_INIT(-1),
> };
>
> +inline int get_nohz_load_balancer(void)
inline?
> +{
> + return atomic_read(&nohz.load_balancer);
> +}
Shouldn't we reset .load_balancer when this CPU is CPU_DOWN'ed ?
Otherwise the timer can migrate to the dead CPU.
Oleg.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/