Re: [PATCH] mflash: Initial support

From: unsik Kim
Date: Thu Mar 05 2009 - 04:25:06 EST


Hello?

First of all, thanks for your kind review and sorry for very late reply.

>
> Have we fully explored the option of controlling this device with the
> current ATA or IDE code, rather than creating a whole new parallel
> block device implementation?
>

As you see, this driver quite similar with ATA code. (especially PATA
platform device driver) I think integrating with ATA is possible. But, I
think integration is not adequate at this time.

Because,

1. ATA layer deals standard ATA protocol. ATA layer have many low-
level device specific interface, but data transfer keeps ATA rule. But,
mflash IO mode doesn't.

2. Even though currently not used in mflash driver code, mflash has
some custom command and modes. (nand fusing, firmware patch,
etc) If this feature supported in linux kernel, ATA layer more altered.

3. Currently PATA platform device driver doesn't support interrupt.
(I'm not sure) But, mflash uses interrupt (polling mode is just for debug).

4. mflash is somewhat under-develop product. Even though some
company already using mflash their own product, I think more time is
needed for standardization of custom command and mode. That time
(maybe October) I will talk to with ATA people. If they accept integration,
I will integrate.

All the other requests will be reflected with upcoming patch.

--
unsik Kim <donari75@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/