Re: [patch 11/11] ftrace plugin for kernel symbol tracing using HWBreakpoint interfaces

[Ingo Molnar]

* Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:

> On Thu, Mar 05, 2009 at 10:13:33AM +0530, prasad@xxxxxxxxxxxxxxxxxx wrote:
> > This patch adds an ftrace plugin to detect and profile memory access over
> > kernel variables. It uses HW Breakpoint interfaces to 'watch memory
> > addresses.
> > 
> > Signed-off-by: K.Prasad <prasad@xxxxxxxxxxxxxxxxxx> 
> > ---
> 
> 
> Hi,
> 
> Nice feature. And moreover the standardized hardware 
> breakpoints could be helpful for tracing.

yeah. The feature is much more alive now.

> Just some comments below.

One other thing:

+#ifdef CONFIG_FTRACE_SELFTEST
+int trace_selftest_startup_ksym(struct tracer *trace, struct trace_array *tr)
+{
+       /* TODO: Will be implemented later */
+       return 0;
+}
+#endif /* CONFIG_FTRACE_SELFTEST */

This needs to be implemented before i can pick the code up into 
tip:tracing, as otherwise we will not notice it fast enough if 
some of this stuff breaks.

Basically the ftrace plugin will be the main usage vector of 
this facility, so the self-test is a must-have.

Looks very nice otherwise.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/