Re: commit "radeonfb: Fix resume from D3Cold on some platforms"breaks resume from RAM on PowerBook

From: Benjamin Herrenschmidt
Date: Wed Mar 04 2009 - 21:26:42 EST


On Wed, 2009-03-04 at 09:38 +0100, Gaudenz Steinlin wrote:
> Hi Benjamin
>
> The commit 1fb25cb8b83e85f5bf1a4adb3c9a254c4ce92405 "radeonfb: Fix resume
> from D3Cold on some platforms" breaks resume from suspend to RAM on my
> PowerBook (Model PowerBook5,8 with ATI Mobility Radeon 9600 M10).
>
> On resume the pulsing led indicating sleep just changes to solid white
> and nothing else happens.
>
> Reverting this commit on top of the current Linus' tree fixes resume.

Ok, so after some tests here on what appear to the the exact same
machine...

I did the commit specifically to -fix- a regression due to upstream
changes, ie, for me it doesn't work without that commit. That is very
weird.

In fact, I just tried also with AGP and DRM enabled with X wobbly
windows etc... and it's working just fine.

I know that the early resume hack I have in there for powerbooks might
be a bit fishy, so please try without it (according to my previous email
on that matter).

Please let me know if that makes a difference.

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/