Re: [PATCH v2] dmaengine: Fix oops on dmatest module unload.

[Dan Williams]

On Thu, Feb 12, 2009 at 5:12 PM, Dan Williams <dan.j.williams@xxxxxxxxx> wrote:
> On Thu, Feb 12, 2009 at 5:30 AM, Thierry Reding
> <thierry.reding@xxxxxxxxxxxxxxxxx> wrote:
>> This patch fixes an oops that happens when the dmatest module is unloaded. The
>> dma_release_channel() function is called on channels that have already been
>> cleaned up (and therefore freed) with dmatest_cleanup_channel().
>>
>> Signed-off-by: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx>
>
> Thanks, applied with Atsushi's ack.
>

...and now it is unapplied :-).  The problem with this patch is that
it releases the channel before dmatest is done with it.  'Cleanup'
followed by 'release' is the right order, just need to save ->chan
before it gets freed.

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/