Re: [PATCH 2/3] c/r: Add CR_COPY() macro (v3)

From: Serge E. Hallyn
Date: Wed Mar 04 2009 - 10:11:57 EST


Quoting Dave Hansen (dave@xxxxxxxxxxxxxxxxxx):
> On Tue, 2009-03-03 at 16:57 -0800, Dan Smith wrote:
> > DH> Did you convince Nathan that this ends up being a good idea?
> >
> > Technically he hasn't seen this version, but my hopes are not high
> > that he will change his mind. If the feedback is that they're not
> > liked, I'll happily remove them.
>
> I just figure if Nathan feels that strongly that we'll encounter more
> people who feel even more so. So, I was curious if he changed his mind
> somehow.

I maintain however that two strong advantages of moving the checkpoint
and restart of simple registers etc into a single function are:

1. we won't forget to add (or accidentally lose) one or the
other
2. any actual special handling at checkpoint or restart, like
the loading of access registers at restart on s390x,
stand out

-serge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/