Re: [PATCH -v2] tracing: lockdep tracepoints

[Török Edwin]

On 2009-03-04 13:32, Peter Zijlstra wrote:
> On Wed, 2009-03-04 at 12:23 +0100, Frederic Weisbecker wrote:
>   
>>> ---
>>> Subject: tracing: lockdep tracepoints
>>> From: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
>>> Date: Tue Mar 03 22:03:08 CET 2009
>>>
>>> Augment the traces with lock names when lockdep is available:
>>>
>>>  1)               |  down_read_trylock() {
>>>  1)               |    _spin_lock_irqsave() {
>>>  1)               |      /* lock_acquire: name: &sem->wait_lock */
>>>  1)   4.201 us    |    }
>>>  1)               |    _spin_unlock_irqrestore() {
>>>  1)               |      /* lock_release: name: &sem->wait_lock */
>>>       
>> Nice idea.
>> I would just suggest to drop the "name:" since the comment is intuitive enough
>> to figure out what we have after lock_{release,acquire}: 
>>     
>
> Makes sense I guess..
>
> Here goes.. one s/name: //g later

Thanks for working on this.
I just booted a kernel with your patch, and it worked.

When I find some time, I will try to write a locklatency tracer that
uses these tracepoints.

Best regards,
--Edwin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/