Re: [PATCH 2/2] unaligned: add load/store_{endian}_noalign API

From: Linus Torvalds
Date: Mon Mar 02 2009 - 19:19:27 EST




On Mon, 2 Mar 2009, Harvey Harrison wrote:
>
> Add a typed API with the usual argument ordering and use load/store,
> this API is also consistent with the aligned versions.

This naming is horrible. It doesn't match the normal pattern we have in
the kernel.

Why not just try to fix the current (well-named) "get_unaligned_le16()"
problems, instead of introducing a new (and badly named) version of them.

So NAK on both of these.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/