Re: [PATCH] isdn: reduce stack size of mISDN_dsp

From: Karsten Keil
Date: Sun Mar 01 2009 - 11:51:53 EST


On Sun, Mar 01, 2009 at 05:32:50PM +0100, Frank Seidel wrote:
> From: Frank Seidel <frank@xxxxxxxxxxx>
>
> Reduce stack size memory footprint of mISDN_dsp.
> (From 1468 bytes for dsp_cmx_send on i386 down
> to 44).
>

I do not think we can use a static buffer here,
we may have multiple instances.

> Signed-off-by: Frank Seidel <frank@xxxxxxxxxxx>
> ---
> drivers/isdn/mISDN/dsp_cmx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- a/drivers/isdn/mISDN/dsp_cmx.c
> +++ b/drivers/isdn/mISDN/dsp_cmx.c
> @@ -1592,7 +1592,8 @@ dsp_cmx_send(void *arg)
> struct dsp_conf_member *member;
> struct dsp *dsp;
> int mustmix, members;
> - s32 mixbuffer[MAX_POLL+100], *c;
> + static s32 mixbuffer[MAX_POLL+100];
> + s32 *c;
> u8 *p, *q;
> int r, rr;
> int jittercheck = 0, delay, i;

--
Karsten Keil
SuSE Labs
ISDN and VOIP development
SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/