Re: [Orinoco-users] linux-firmware binary corruption with gitweb
From: Pavel Roskin
Date: Sun Mar 01 2009 - 00:47:59 EST
On Sat, 2009-02-28 at 19:24 +0000, Dave wrote:
> I'm aware of at least a couple users of orinoco who have picked up
> corrupt firmware# from the linux-firmware tree*.
>
> I've verified that the firmware in the repository itself is correct.
>
> It appears that downloading the file using the blob/raw links from
> gitweb causes the corruption (0xc3 everywhere). At least it does with
> firefox.
I can confirm the problem with Firefox 3.0.6. But it's not "0xc3
everywhere". The corrupted file is a result of recoding from iso-8859-1
to utf-8. The correct agere_sta_fw.bin is 65046 bytes long. The
corrupted agere_sta_fw.bin is 89729 bytes long.
There is a way to recode the original binary with GNU recode:
recode utf8..iso8859-1 agere_sta_fw.bin
wget 1.11.4 also gets a corrupted file 89729 bytes long.
$ wget "http://git.kernel.org/?p=linux/kernel/git/dwmw2/linux-firmware.git;a=blob;f=agere_sta_fw.bin;h=bae000f5a7162f5a5b052a2f5b78016e95f825c5;hb=d4cfa9f14c55e9d62f053a542fac21744f22546b";
--2009-03-01 00:42:38-- http://git.kernel.org/?p=linux/kernel/git/dwmw2/linux-firmware.git;a=blob;f=agere_sta_fw.bin;h=bae000f5a7162f5a5b052a2f5b78016e95f825c5;hb=d4cfa9f14c55e9d62f053a542fac21744f22546b
Resolving git.kernel.org... 204.152.191.40, 149.20.20.136
Connecting to git.kernel.org|204.152.191.40|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [application/octet-stream]
Saving to: `index.html?p=linux%2Fkernel%2Fgit%2Fdwmw2%2Flinux-firmware.git;a=blob;f=agere_sta_fw.bin;h=bae000f5a7162f5a5b052a2f5b78016e95f825c5;hb=d4cfa9f14c55e9d62f053a542fac21744f22546b'
[ <=> ] 89,729 237K/s in 0.4s
2009-03-01 00:42:39 (237 KB/s) - `index.html?p=linux%2Fkernel%2Fgit%2Fdwmw2%2Flinux-firmware.git;a=blob;f=agere_sta_fw.bin;h=bae000f5a7162f5a5b052a2f5b78016e95f825c5;hb=d4cfa9f14c55e9d62f053a542fac21744f22546b' saved [89729]
curl 7.18.2 also get the corrupted file:
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 89729 0 89729 0 0 111k 0 --:--:-- --:--:-- --:--:-- 191k
My strong impression is that the recoding takes place on the server. I
think the bug should be reported to the gitweb maintainers unless it a
local breakage on the kernel.org site.
--
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/