Re: [PATCH 1/1] ath5k: fix hw rate index condition

From: Jiri Slaby
Date: Sat Feb 28 2009 - 18:08:29 EST


On 15.2.2009 14:47, Bob Copeland wrote:
On Mon, Feb 02, 2009 at 01:27:39PM +0530, Dhaval Giani wrote:
So I finally managed to hit this on 2.6.29-rc3. It is hard to
reproduce, so I hope so much information is enough to give you a good
guess. This time it hit while trying to connect to an open network at
the airport.

WARNING: at net/mac80211/rx.c:2236 __ieee80211_rx+0x96/0x571 [mac80211]()
Hardware name: 2007CS3
RATE=255, BAND=8

band is supposed to be sc->curband? 8 is way wrong.

If you look into the patch which outputs this (backtrace in this thread), sband->n_bitrates is 8. I have no idea what I have been smoking the day I wrote it, but BAND= for sure isn't the right name for that thing. Sorry for the confusion.

rate could be 255
if, for some reason, the hardware rate wasn't in the rate table.

So, we have a fix for this, right? I mean the u8->s8 sc->rate_idx conversion or alike...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/