[PATCH] Use a format string for linux_banner

From: Alex Riesen
Date: Sat Feb 28 2009 - 08:48:18 EST


Signed-off-by: Alex Riesen <raa.lkml@xxxxxxxxx>
---

Stefan Richter, Sat, Feb 28, 2009 13:01:07 +0100:
> [+ application/octet-stream attachment, base64 encoded]
>
> Please send patches as inline text or at least as plaintext attachment
> in ascii encoding. linux/Documentation/email-clients.txt has help.

Couldn't. Had to either choose the corporate firewal and gmail, or the
Exchange-thing. Both will corrupt patches, unless send as attachment.
Decided not to expose the corporate mail address.
Anyway, resending from home now (back then couldn't send from home
either: was changing providers and had no usable link for a week.
Tell about coincidences...)

> > - printk(linux_banner);
> > + printk("%s", linux_banner);
>
> Better than that:
>
> - printk(KERN_NOTICE);
> - printk(linux_banner);
> + printk(KERN_NOTICE "%s", linux_banner);
>

Missed the line before. Poor blind me.

init/main.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/init/main.c b/init/main.c
index 8442094..77fc028 100644
--- a/init/main.c
+++ b/init/main.c
@@ -553,8 +553,7 @@ asmlinkage void __init start_kernel(void)
tick_init();
boot_cpu_init();
page_address_init();
- printk(KERN_NOTICE);
- printk(linux_banner);
+ printk(KERN_NOTICE "%s", linux_banner);
setup_arch(&command_line);
mm_init_owner(&init_mm, &init_task);
setup_command_line(command_line);
--
1.6.2.rc2.31.gce6e3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/