Re: [PATCH 2/2] x86-64: seccomp: fix 32/64 syscall hole

From: Ingo Molnar
Date: Sat Feb 28 2009 - 02:32:27 EST



* Roland McGrath <roland@xxxxxxxxxx> wrote:

> +#ifdef CONFIG_COMPAT
> + if (is_compat_task())
> syscall = mode1_syscalls_32;
> #endif

btw., shouldnt is_compat_task() expand to 0 in the
!CONFIG_COMPAT case? That way we could remove this #ifdef too.
(and move the first #ifdef inside the array initialization so
that we always have a mode1_syscalls_32[] array.)

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/