Re: [PATCH] Don't profile branches in arm's boot decompressor

[Steven Rostedt]

Thanks Uwe!



On Fri, Feb 27, 2009 at 10:09:43PM +0100, Uwe Kleine-K??nig wrote:
> This fixes many compile errors for arch/arm/boot/compressed/misc.c of
> the type:
> 
> 	arch/arm/boot/compressed/misc.c:127: error: section attribute cannot be specified for local variables
> 
> Fix was suggested by Steven Rostedt in #linux-rt.
> 
> Signed-off-by: Uwe Kleine-K??nig <u.kleine-koenig@xxxxxxxxxxxxxx>
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxx>
> 
> ---
>  arch/arm/boot/compressed/Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile
> index fbe5eef..0bcc98c 100644
> --- a/arch/arm/boot/compressed/Makefile
> +++ b/arch/arm/boot/compressed/Makefile
> @@ -89,7 +89,7 @@ LDFLAGS_vmlinux += -p --no-undefined -X \
>  
>  # Don't allow any static data in misc.o, which
>  # would otherwise mess up our GOT table
> -CFLAGS_misc.o := -Dstatic=
> +CFLAGS_misc.o := -Dstatic= -DDISABLE_BRANCH_PROFILING

Could you also add a comment saying something to the effect:

# The branch profiler requires static variables.
# No need to profile the boot up code, so simply disable it.

Thanks,

-- Steve

>  
>  $(obj)/vmlinux: $(obj)/vmlinux.lds $(obj)/$(HEAD) $(obj)/piggy.o \
>  	 	$(addprefix $(obj)/, $(OBJS)) FORCE
> -- 
> tg: (db50eec..) t/ftrace/fix-PROFILE_ALL_BRANCHES (depends on: tip/master)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/