Re: [patch 2.6.29-rc3-git 2/2] USB: disable twl4030 USB regulatorswhen cable unplugged

[Liam Girdwood]

On Fri, 2009-02-27 at 08:19 +0200, Kalle Jokiniemi wrote:
> On Thu, 2009-02-26 at 14:40 -0800, David Brownell wrote:
> > On Thursday 26 February 2009, Liam Girdwood wrote:
> > > On Sun, 2009-02-08 at 10:52 -0800, David Brownell wrote:
> > > > From: Kalle Jokiniemi <kalle.jokiniemi@xxxxxxxxx>
> > > > 
> > > > This patch disables LDO regulators VUSB1V5, VUSB1V8, and VUSB3V1
> > > > when the USB cable is unplugged, to eliminate that source of power
> > > > waste.  (Enabled LDOs consume power at all times.)
> > > > 
> > > > Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi@xxxxxxxxx>
> > > > Signed-off-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
> > > > ---
> > > > Depends on the twl4030 regulator driver, so I'm suggesting this
> > > > be merged (with that driver) through the regulator patch queue
> > > > to simplify things.
> > > > 
> > > >  drivers/usb/otg/twl4030-usb.c |   30 ++++++++++++++++++++++++------
> > > >  1 file changed, 24 insertions(+), 6 deletions(-)
> > > 
> > > Applied.
> > 
> > Better suggestion:  grab Kalle's updated patch from Greg's USB
> > queue:
> > 
> >   http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-04-usb/
> > 
> > patch name usb-twl-disable-vusb-regulators-when-cable-unplugged.patch
> 
> 
> Yep, this previous one lacked some error checks and a build dependency
> to TWL_REGULATOR. 

I've now removed this patch from the regulator tree. I guess Greg will
take care of it via the USB tree now.

Thanks

Liam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/