Re: [PATCH][retry 2] Conform L3 Cache Index Disable to Linuxstandards From: Eric Lammerts <eric@lammerts.org>

From: Ingo Molnar
Date: Fri Feb 27 2009 - 03:03:19 EST



* Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Fri, 20 Feb 2009 15:50:47 -0600
> Mark Langsdorf <mark.langsdorf@xxxxxxx> wrote:
>
> > Add ABI Documentation entry and fix some /sys directory formating
> > issues with the L3 Cache Index Disable feature for future AMD
> > processors. __Add a check to disable it for family 0x10 models
> > that do not support it yet.
>
> x86_64 allnoconfig:
>
> arch/x86/kernel/cpu/intel_cacheinfo.c:556: warning: 'free_cache_attributes' defined but not used
> arch/x86/kernel/cpu/intel_cacheinfo.c:596: warning: 'detect_cache_attributes' defined but not used
>
> Fixing these revealed another shower of unused functions.
> Fixing those led to an even bigger shower.
>
> Obviously, the code is a mess and needs some thought,
> understanding and restructuring so that mere mortals can
> correctly modify it.
>
> I'll drop the patches. Please test version 3 a bit better?

Yes. I'll pick it up into the x86 tree once it works and builds
warning-free.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/