[PATCH] change cpuacct usage percpu format v2

From: KAMEZAWA Hiroyuki
Date: Fri Feb 27 2009 - 02:31:02 EST


From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>

cpuacct.usage_percpu shows per cpu usage information via cgroupfs.
It shows all "present" cpus information and "whose information ?"
is explained just by index of data implicitly.

IIRC, there is physical cpu hotplug system and it can remove
cpus and change map. Considering a software which records
this information pediodically(like sar), its better to show id of cpu
in explict way.

Changelog: v1 -> v2
- added ":" instead of " " as split charactor.

Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
---
Index: mmotm-2.6.29-Feb26/kernel/sched.c
===================================================================
--- mmotm-2.6.29-Feb26.orig/kernel/sched.c
+++ mmotm-2.6.29-Feb26/kernel/sched.c
@@ -9719,7 +9719,7 @@ static int cpuacct_percpu_seq_read(struc

for_each_present_cpu(i) {
percpu = cpuacct_cpuusage_read(ca, i);
- seq_printf(m, "%llu ", (unsigned long long) percpu);
+ seq_printf(m, "%d:%llu\n", i, (unsigned long long) percpu);
}
seq_printf(m, "\n");
return 0;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/