Re: [ath5k-devel] [PATCH 1/1] ath5k: fix hw rate index condition

From: Jiri Slaby
Date: Thu Feb 26 2009 - 18:33:19 EST


On 27.2.2009 00:28, Bob Copeland wrote:
hw_to_driver_rix() returns sc->rate_idx[x][y] as an int, and that
array is initialized to (u8)-1 for invalid rates. So, it can
return 255 if the hardware rate index (y) is bad, then the check
"rxs.rate_idx>= 0" would always be true, right? If it's not a
real bug yet, it likely will be one day :)

Ah, yes, it really is a bug(tm), care to post a fix?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/