Re: [RFC][PATCH] signals: don't copy siginfo_t on dequeue

[Vegard Nossum]

2009/2/26 Oleg Nesterov <oleg@xxxxxxxxxx>:
> So. dequeue_signal() returns NULL if there is no siginfo queued. In that
> case we assume that the signal is not pending.
>
> But this is not right. Think about SEND_SIG_FORCED, or __sigqueue_alloc()
> failure when the signal is sent. Or look at zap_other_threads() for example,
> it just sets the bit in ->pending but doesn't queue siginfo.

I will investigate. Thanks for looking, and thanks for the pointers :-)


Vegard

-- 
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
	-- E. W. Dijkstra, EWD1036
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/