Re: [PATCH 5/6] [-mm] epoll: clean up ep_modify

[Davide Libenzi]

On Tue, 24 Feb 2009, Tony Battersby wrote:

> ep_modify() doesn't need to set event.data from within the ep->lock
> spinlock as the comment suggests.  The only place event.data is used
> is ep_send_events_proc(), and this is protected by ep->mtx instead
> of ep->lock.  Also update the comment for mutex_lock() at the top
> of ep_scan_ready_list(), which mentions epoll_ctl(EPOLL_CTL_DEL)
> but not epoll_ctl(EPOLL_CTL_MOD).
> 
> ep_modify() can also use spin_lock_irq() instead of
> spin_lock_irqsave().

Pre-mtx stuff.

Acked-by: Davide Libenzi <davidel@xxxxxxxxxxxxxxx>


- Davide


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/