Re: [tip:core/header-fixes] compiler-gcc4: conditionalize #error on __KERNEL__

[Arnd Bergmann]

On Thursday 26 February 2009, H. Peter Anvin wrote:
> compiler-gcc4: conditionalize #error on __KERNEL__
> 
> Impact: Fix for exported headers
> 
> We only want to error out on specific gcc versions if we are actually
> building the kernel, so conditionalize the #if...#error on __KERNEL__.
> 
> Based on a patchset by Arnd Bergmann <arnd@xxxxxxxx>.
> 
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: H. Peter Anvin <hpa@xxxxxxxxxxxxxxx>

No kidding. It never occurred to me that this hunk from my patch was
any good. It just happened that I was cross compiling for powerpc
and only had a ppc64-gcc-4.1.0 installed on my laptop, so I commented
out that line with the intention of reverting that change after a
successful build...

Good catch!

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/