[PATCH] fsldma: dev_err 1 too early.

From: Roel Kluin
Date: Wed Feb 25 2009 - 07:47:20 EST


If unsuccessful, i reaches 101 after the loop, so 100 is still success.

Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
---
diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
index 70126a6..444c4e4 100644
--- a/drivers/dma/fsldma.c
+++ b/drivers/dma/fsldma.c
@@ -168,7 +168,7 @@ static void dma_halt(struct fsl_dma_chan *fsl_chan)

while (!dma_is_idle(fsl_chan) && (i++ < 100))
udelay(10);
- if (i >= 100 && !dma_is_idle(fsl_chan))
+ if (i > 100 && !dma_is_idle(fsl_chan))
dev_err(fsl_chan->dev, "DMA halt timeout!\n");
}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/