Re: [PATCH] drm: edid revision 0 is valid

From: Jesse Barnes
Date: Tue Feb 24 2009 - 20:44:49 EST


On Tuesday, February 24, 2009 5:31:53 pm Kyle McMartin wrote:
> From: Kyle McMartin <kyle@xxxxxxxxxx>
>
> edid->revision == 0 should be valid (at least, so the error message
> indicates. :) and wikipedia seems to indicate that EDID 1.0 existed.
>
> We can dump the entire check, since edid->revision is a u8, so
> it can't ever be less than 0.
>
> Marko reports in RH bz#476735 that his monitor claims to be
> EDID 1.0, and therefore hits the check and is stuck at 800x600 because
> of it.
>
> Reported-by: Marko Ristola <marko.ristola@xxxxxxxxxxx>
> Signed-off-by: Kyle McMartin <kyle@xxxxxxxxxx>

Heh, yeah this makes the code correct *and* match the message. Thanks.

Acked-by: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxx>

--
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/