Re: [Linux 2.6.29-rc6] [drm:i915_set_status_page] *ERROR* can notioremap virtual address for G33 hw status page

[Linus Torvalds]

On Wed, 25 Feb 2009, Dave Airlie wrote:
> > 
> > The other question is, why did the ioremap_wc() fail? Why doesnt 
> > it fall back to UC transparently?
>
> I'm sort of worried the drivers are going to end up doing, which at
> the moment is the only option that will work.
> 
> blah = ioremap_wc();
> if (!blah)
> 	blah = ioremap_nocache();
> 
> which seems pointless so this is a good point, where is the fallback?

I agree.

We should not fail the ioremap_wc(), we should just fall back to nocache, 
(possibly with a warning). In fact I thought we did exactly that, but 
maybe it only happens in certain directions.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/