Re: [PATCH] AMD Geode CS5535/5536 GPIO driver

From: Jordan Crouse
Date: Sun Feb 15 2009 - 17:56:24 EST


Alessandro Zummo wrote:
On Thu, 5 Feb 2009 16:12:20 -0800
David Brownell <david-b@xxxxxxxxxxx> wrote:

Unless this hardware misbehaves when both output and input
modes are enabled (e.g. in the window between those two calls),
I'd suggest just not clearing INPUT_ENABLE. It's legit to
ask for the *actual* value of an output line, e.g. for when
it uses open drain mode. (And didn't this hardware have an
option for open drain GPIO signaling?)

seems reasonable,
I'll let the Geode people decide what to do here...

Sorry, I'm just getting around to answering this. I don't recall any situation where the hardware would mis-behave, but you never know with this bit of silicon.

I say leave them both on, and revisit it if you get flamed.

Jordan




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/