Re: [PATCH] hwmon/hdaps: Fix bug 7154 inversion of separate axis

[Shem Multinymous]

Hi Frank,

On Fri, Feb 13, 2009 at 7:38 AM, Frank Seidel <fseidel@xxxxxxx> wrote:
> From: Frank Seidel <frank@xxxxxxxxxxx>
>
> Fix for kernel.org bug #7154:hdaps inversion of
> each axis. This version is based on the work
> from Michael Ruoss <miruoss@xxxxxxxxxxxxxxx>.
>
> Signed-off-by: Frank Seidel <frank@xxxxxxxxxxx>
> ---
>  drivers/hwmon/hdaps.c |   49 ++++++++++++++++++++++++++++---------------------
>  1 file changed, 28 insertions(+), 21 deletions(-)
>
> --- a/drivers/hwmon/hdaps.c
> +++ b/drivers/hwmon/hdaps.c
> @@ -65,6 +65,10 @@
>  #define HDAPS_INPUT_FUZZ       4       /* input event threshold */
>  #define HDAPS_INPUT_FLAT       4
>
> +#define HDAPS_X_AXIS           1UL
> +#define HDAPS_Y_AXIS           2UL
> +#define HDAPS_BOTH_AXES                3UL

There are more possibilities than these: axes could also switched, for
a total of 8 possibilities.
See the table at the bottom of the tp_smapi page
(http://www.thinkwiki.org/wiki/Tp_smapi), or hdaps.c inside the
tp_smapi package, for more model-specific information.
It would be nice if you made the interface (constants and their
meaning) the same as in the tp_smapi version of hdaps, which is
already widely deployed and packaged by several distros.

  Shem
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/