Re: irq-disabled vs vmap vs text_poke

From: Mathieu Desnoyers
Date: Fri Feb 13 2009 - 09:25:38 EST


* Ingo Molnar (mingo@xxxxxxx) wrote:
>
> * Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> > > I think I got a mostly working patch cobbled together sitting here
> > > somewhere. I was waiting for some _really_ good use case before spending
> > > more time on it. I would prefer if at all possible to do vmap operations
> > > in sleepable, process context.
> >
> > Agreed, I think we want to fix text_poke() and make the vmap/vunmap()
> > ops yell louder at violations of these rules.
> >
> > I'm just totally clueless wrt text_poke() hence this email ;-)
>
> also, this started triggering yesterday for the first time - and never
> saw it before. Has some commit caused this side-effect?
>
> It triggers during kprobes self-test - has that been improved recently?
>

When is this self-test run ? If it's at early boot while still in UP
with interrupts off, kprobes should probably use text_poke_early()
rather than text_poke().

Mathieu


--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/