Re: [PATCHv7] lis3lv02d: support both one- and two-byte sensors

[Andrew Morton]

On Wed, 11 Feb 2009 23:44:20 +0100
Giuseppe Bilotta <giuseppe.bilotta@xxxxxxxxx> wrote:

> On Wed, Feb 11, 2009 at 11:38 PM, Andrew Morton
> <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > On Wed, 11 Feb 2009 11:06:43 +0100
> > Giuseppe Bilotta <giuseppe.bilotta@xxxxxxxxx> wrote:
> >
> >> Sensors responding with 0x3B to WHO_AM_I only have one data register per
> >> direction, thus returning a signed byte from the position which is
> >> occupied by the MSB in sensors responding with 0x3A.
> >>
> >> Since multiple sensors share the reply to WHO_AM_I, we rename the
> >> defines to better indicate what they identify (family of single and
> >> double precision sensors).
> >>
> >> We support both kind of sensors by checking for the sensor type on init
> >> and defining appropriate data-access routines and sensor limits (for the
> >> joystick) depending on what we find.
> >>
> >
> > Which tree is this patch against?
> >
> >> --- a/drivers/hwmon/lis3lv02d.c
> >> +++ b/drivers/hwmon/lis3lv02d.c
> >> @@ -53,9 +53,6 @@
> >>   * joystick.
> >>   */
> >>
> >> -/* Maximum value our axis may get for the input device (signed 12 bits) */
> >> -#define MDPS_MAX_VAL 2048
> >> -
> >>  struct acpi_lis3lv02d adev = {
> >>       .misc_wait   = __WAIT_QUEUE_HEAD_INITIALIZER(adev.misc_wait),
> >>  };
> >
> > Current Linus mainline has
> >
> > struct acpi_lis3lv02d adev;
> > EXPORT_SYMBOL_GPL(adev);
> >
> > here.
> 
> I based my patch on Linus' tree, plus Pavel's patch which I've been
> told is on your tree.

What is "Pavel's patch"?  Pavel writes lots of patches :(

> Is your tree available for git?

http://userweb.kernel.org/~akpm/mmotm/mmotm-readme.txt

> I can try basing it on yours directly.

That shouldn't be needed.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/