Re: [PATCH 2/3] x86: Pass in pt_regs pointer for syscalls thatneed it

[Ingo Molnar]

* Tejun Heo <htejun@xxxxxxxxx> wrote:

> Brian Gerst wrote:
> > x86-64 doesn't have the tail-call problem because it doesn't use the
> > pt_regs on stack trick for syscall args.  All the args are passed in
> > registers.
> 
> Yeah, I was saying that we can do about the same thing on x86_32 by
> passing in pointer to pt_regs and defining proper syscall wrappers.
> It will cost a bit of performance by increasing register pressure tho.

Do you mean converting:

ptregscall int sys_execve(struct pt_regs *regs, char __user *u_filename,
                          char __user * __user *argv,
                          char __user * __user *envp)

to:

ptregscall int sys_execve(struct pt_regs *regs)
{
	char __user *u_filename		= syscall_arg1(regs);
	char __user * __user *argv	= syscall_arg2(regs);
	char __user * __user *envp	= syscall_arg3(regs);

etc.?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/