Re: [PATCH 0/3] x86: Fix pt_regs passed by value

From: Tejun Heo
Date: Wed Feb 11 2009 - 09:16:34 EST


Ingo Molnar wrote:
> * Brian Gerst <brgerst@xxxxxxxxx> wrote:
>
>> Several syscalls and one trap handler currently rely on the pt_regs
>> struct being passed in by value. This causes problems with stack
>> protector, and can also cause problems with corruption due to tail-call
>> optimization. Change them to use a pointer to the pt_regs struct
>> instead.
>
> looks good! Applied them to tip:core/percpu, thanks Brian.
>
> Tejun, i have added your Acked-by lines. (let me know if that's
> incorrect). The review feedback you gave is correct and can/should
> be addressed in separate patches.

Yeah, sure. I like the direction. Brian, are you interested in
pursuing further changes?

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/