Re: Build failure with latest -git: btrfs on ppc64

[Chris Mason]

On Sat, 2009-02-07 at 18:24 -0500, Kyle McMartin wrote:
> On Sat, Feb 07, 2009 at 03:50:39PM -0500, Chuck Ebbert wrote:
> > fs/btrfs/locking.c: In function 'btrfs_path_lock_waiting':
> > fs/btrfs/locking.c:254: error: implicit declaration of function '__raw_spin_is_contended'
> > 
> > Looks like spin_is_contended() is only available on mips and x86??
> > 
> 
> Looks to be if there are other folks in line for the ticket lock.
> 
> Arguably this should probably be something silly in spinlock.h like,
> 
> #ifndef __raw_spin_is_contended
> # define spin_is_contended (0)
> #else
> # define spin_is_contended(x) __raw_spin_is_contended((x))
> #endif
> 
> or something since in theory anybody has a chance of acquiring it next
> (well, lies because caches bias, but there's no waiters at least.)
> 
> Either that, or we just define it to be spin_is_locked if the assumption
> is that the lock will continue to be locked...

Ok, I thought this would be defined to something simple for the
non-ticket users, should I just not be using this call?  

-chris


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/