Re: [PATCH 1/3] cpumask: remove dangerous CPU_MASK_ALL_PTR,&CPU_MASK_ALL.

[Ingo Molnar]

* Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:

> (Thanks to Al Viro for reminding me of this, via Ingo)
> 
> CPU_MASK_ALL is the (deprecated) "all bits set" cpumask, defined as so:
> 
> 	#define CPU_MASK_ALL (cpumask_t) { { ... } }
> 
> Taking the address of such a temporary is questionable at best,
> unfortunately 321a8e9d (cpumask: add CPU_MASK_ALL_PTR macro) added
> CPU_MASK_ALL_PTR:
> 
> 	#define CPU_MASK_ALL_PTR (&CPU_MASK_ALL)
> 
> Which formalizes this practice.  One day gcc could bite us over this
> usage (though we seem to have gotten away with it so far).
> 
> So replace everywhere which used &CPU_MASK_ALL or CPU_MASK_ALL_PTR
> with the modern "cpu_all_mask" (a real struct cpumask *), and remove
> CPU_MASK_ALL_PTR altogether.
> 
> Also remove the confusing and deprecated large-NR_CPUS-only
> "cpu_mask_all".
> 
> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>

In general this should be expressed via this tag:

	Reported-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/