Re: [PATCH] x86: check_timer cleanup

[Ingo Molnar]

* Yinghai Lu <yinghai@xxxxxxxxxx> wrote:

> Impact: remove extra unmask, and pair disable/enable
> 
> for edge trigger io-apic routing, already unmasked via setup_IO_APIC_irq,
> so don't unmask it again.
> 
> also do call local_irq_disable() between timer_irq_works(), between it does call
> local_irq_enable() inside.
> also remove not needed apic version reading for 64bit
> 
> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
> 
> ---
>  arch/x86/kernel/io_apic.c |   30 ++++++++++++++++++++++--------
>  1 file changed, 22 insertions(+), 8 deletions(-)

applied to tip/x86/apic, thanks Yinghai. Maybe this even solves some of the spurious 
detection troubles we had in this code.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/