Re: WOL with forcedeth broken sincef55c21fd9a92a444e55ad1ca4e4732d56661bf2e

[Tobias Diedrich]

Philipp Matthias Hahn wrote:
> Somewhere between 2.6.26 and 2.6.27 WOL stopped working on my MS-7350
> motherboard with an "nVidia Corporation MCP51 Ethernet Controller (rev a3)".
> 	"etherwake 00:19:db:f2:e1:35" did not work
> 	"etherwake 35:e1:f2:db:19:00" did work
> Since I did a BIOS update during the same time window I (wrongly) put
> the fault on the BIOS. (See /sys/class/dmi/id/modalias for yourself:
> dmi:bvnAmericanMegatrendsInc.:bvrV1.7:bd07/29/2008:svnMSI:pnMS-7350:pvr1.0:rvnMSI:rnMS-7350:rvr1.0:cvnToBeFilledByO.E.M.:ct3:cvrToBeFilledByO.E.M.:
> )

Hmm, I had not tried WOL for some time.
With 2.6.29-rc3 is see the following behaviour:

State            WOL Behaviour
------------------------------
shutdown         reversed MAC
disk/shutdown    reversed MAC
disk/platform    OK

Apparently nv_restore_mac_addr() restores the MAC in the wrong order
for WOL (at least for my PCI_DEVICE_ID_NVIDIA_NVENET_15).  platform
works, because the MAC is not touched in the nv_suspend() path.

A possible fix might be to only call nv_restore_mac_addr() if
system_state != SYSTEM_POWER_OFF.

-- 
Tobias						PGP: http://9ac7e0bc.uguu.de
ããããããååååçãããããããäããããããã
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/