Re: [git pull -tip] headers_check fixes for other architectures
From: Jaswinder Singh Rajput
Date: Fri Feb 06 2009 - 13:13:06 EST
On Fri, 2009-02-06 at 18:24 +0100, Sam Ravnborg wrote:
> >
> > Is this safe OR we can make it more safer:
> >
> > Subject: [PATCH] make linux/types.h as assembly safe
> >
> > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@xxxxxxxxx>
> > ---
> > include/linux/types.h | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/include/linux/types.h b/include/linux/types.h
> > index 712ca53..c30973a 100644
> > --- a/include/linux/types.h
> > +++ b/include/linux/types.h
> > @@ -1,6 +1,7 @@
> > #ifndef _LINUX_TYPES_H
> > #define _LINUX_TYPES_H
> >
> > +#ifndef __ASSEMBLY__
> > #ifdef __KERNEL__
> >
> > #define DECLARE_BITMAP(name,bits) \
> > @@ -212,5 +213,5 @@ struct ustat {
> > };
> >
> > #endif /* __KERNEL__ */
> > -
> > +#endif /* __ASSEMBLY__ */
> > #endif /* _LINUX_TYPES_H */
>
> This is wrong...
> We should include the assumed assembly safe asm/types.h
> outside the __ASEMBLY__ ifdef.
>
Subject: [PATCH] make linux/types.h as assembly safe
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@xxxxxxxxx>
---
include/linux/types.h | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/include/linux/types.h b/include/linux/types.h
index 712ca53..e1322a7 100644
--- a/include/linux/types.h
+++ b/include/linux/types.h
@@ -1,6 +1,10 @@
#ifndef _LINUX_TYPES_H
#define _LINUX_TYPES_H
+#ifdef __ASSEMBLY__
+# include <asm/types.h>
+#else /* __ASSEMBLY__ */
+
#ifdef __KERNEL__
#define DECLARE_BITMAP(name,bits) \
@@ -212,5 +216,5 @@ struct ustat {
};
#endif /* __KERNEL__ */
-
+#endif /* __ASSEMBLY__ */
#endif /* _LINUX_TYPES_H */
--
1.6.0.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/