Re: [PATCH] [resend] Resume from hibernation fails with pata_it821xRAID volume

From: Alan Cox
Date: Fri Feb 06 2009 - 12:56:44 EST


> See CodingStyle chapter 8 for the preferred multiline comment style.
>
> > + memset(&id[ATA_ID_SERNO], 0x20, ATA_ID_SERNO_LEN);
>
> Why not ' '?
>
> MBR, Sergei


Digging into the docs the RAID serial number (and what that means isn't
defined anywhere I can see) is byte offset 54-73 in each of the 4 128
byte blocks returned by the chip status query we do at boot
(it821x_probe_firmware).

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/