Re: [PATCH 5 of 7] x86/paravirt: add register-saving thunks to reducecaller register pressure

From: Jeremy Fitzhardinge
Date: Fri Feb 06 2009 - 11:37:33 EST


Andi Kleen wrote:
I had something like this (but not as generic) for the old pre
unification semaphores on x86-64 too. I think it's a generally useful
facility for lots of things (in fact I've been asking gcc developers
for providing this in a general way for some time).

What other users do you have in mind?

So I would suggest to move the necessary macros to do that outside
paravirt.h into a separate include so that it can be used independently
and not call it PV_*.

That wouldn't be too hard to do, but I don't think its something we should do lightly. There are quite a few pitfalls, and the bugs can get pretty obscure. It would also mean bringing out a lot of the PV_CALL machinery, and I'm not sure we really want to give that too much exposure in the light of day.

J

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/