Re: [git pull -tip] headers_check fixes for other architectures

From: Ingo Molnar
Date: Fri Feb 06 2009 - 10:57:21 EST



* Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote:

> Taking this further, if you're including linux/types.h into another
> header file, you're including it because you want some C type from
> that or an included file. Use of that type is also not ASM friendly,
> so the use is going to have to be excluded by ifndef in that header.

There's a ton of header files that can be included in assembly code and
which also contain C declarations and definitions. This is achieved by
adding a:

#ifndef __ASSEMBLY__
#endif

Blocks around the C code. Especially for smallish or single-purpose files
this is often a cleaner method than splitting the file.

There's more than 40 such headers on x86 alone.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/