Re: [PATCH 6/6] x86: unify fixmap.h

[Ingo Molnar]

* Gustavo F. Padovan <gustavo@xxxxxxxxxxxxxxxxx> wrote:

> This patch unify fixmap_32.h and fixmap_64.h into fixmap.h.
> Things that we can't merge now are using CONFIG_X86_{32,64}
> (e.g.:vsyscall and EFI)
> 
> Signed-off-by: Gustavo F. Padovan <gustavo@xxxxxxxxxxxxxxxxx>
> Acked-by: Glauber Costa <gcosta@xxxxxxxxxx>
> ---
>  arch/x86/include/asm/fixmap.h    |  153 +++++++++++++++++++++++++++++++++++++-
>  arch/x86/include/asm/fixmap_32.h |  119 -----------------------------
>  arch/x86/include/asm/fixmap_64.h |   94 -----------------------
>  3 files changed, 151 insertions(+), 215 deletions(-)
>  delete mode 100644 arch/x86/include/asm/fixmap_32.h
>  delete mode 100644 arch/x86/include/asm/fixmap_64.h

Please split this patch up into 3 parts:

 #1: "x86: prepare fixmap_32.h for unification"
 #2: "x86: prepare fixmap_64.h for unification"
 #3: "x86: mechanic unification of fixmap_32/64.h => fixmap.h"

ok?

That way it's reviewable what happened during the unification,
with the above patch it isnt.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/