Re: [PATCH 2/3] work_on_cpu: Use our own workqueue.

From: Rusty Russell
Date: Wed Feb 04 2009 - 18:46:26 EST


On Thursday 05 February 2009 08:18:23 Andrew Morton wrote:
> I expect that the same argument applies to most of the set_cpus_allowed()
> callsites - they're run by root-only code. Sure, root can (with
> careful timing) move root's own thread onto the wrong CPU in the middle
> of microcode loading. In which case root gets to own both pieces.

Sorry, I don't accept this at all. It's completely reasonable for me to write a tool which clears all tasks off a cpu. We wrote an API to do it, now we're going to say don't use it?

Yes, it's a pain to fix. Yes, we should never have been doing it this way in the first place. But let's not blame the users.

Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/