Re: [PATCH V4] Allow SysRq emergency thaw to thaw frozenfilesystems

From: Andrew Morton
Date: Tue Feb 03 2009 - 17:24:23 EST


On Tue, 03 Feb 2009 16:07:06 -0600
Eric Sandeen <sandeen@xxxxxxxxxx> wrote:

> Andrew Morton wrote:
> > On Mon, 02 Feb 2009 16:55:18 -0600
> > Eric Sandeen <sandeen@xxxxxxxxxx> wrote:
> >
> >> (this version fixes a couple small issues raised by Randy Dunlap)
> >> (and adds sb_lock locking I forgot, as akpm pointed out)
> >> (Randy's CONFIG_BLOCK fix should still apply over this)
> >
> > <converts it to a delta so I can see what you did>
>
> Sorry, didn't know if you want deltas on top of old patches or new
> respun patches. Guess now I know :)

There's no easy answer. For new reviewers/testers, the whole patch is better.

But for people who reviewed/tested the earlier patch, the delta is
better.

So a replacement patch is usually OK. I will turn it into a delta with
a flick of the wrist and those people who I cc'ed on the patch (and
mm-commits subscribers) will get to see the delta.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/