Re: [PATCH tip 1/1] blktrace: fix coding style in recent patches

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:

> Impact: cleanup
>     
> I introduced some, then, while testing with checkpatch --file
> block/blktrace.c I saw some long lines and fixed those too, some were
> even from older patches I sent, shame on me ;-\
>     
> Cc: Jens Axboe <jens.axboe@xxxxxxxxxx>
> Reported-by: Ingo Molnar <mingo@xxxxxxx>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>

applied to tip:tracing/blktrace, thanks Arnaldo!

btw., there's only one warning remaining in all of blktrace.c:

| CHECK: memory barrier without comment
| #555: FILE: blktrace.c:555:
| +			smp_mb();
|
| total: 0 errors, 1 warnings, 1 checks, 1549 lines checked

and here checkpatch is kind of right that we should document this particular 
smp_mb(). If you stick a comment in front of that statement, explaining that 
barrier, then checkpatch will stop complaining.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/