Re: [PATCH 2/2] bio.h: If they MUST be inlined, then use __always_inline

[Jens Axboe]

On Tue, Feb 03 2009, Andrew Morton wrote:
> On Sun,  1 Feb 2009 22:07:31 -0200 Alberto Bertogli <albertito@xxxxxxxxxxxxxx> wrote:
> 
> > bvec_kmap_irq() and bvec_kunmap_irq() comments say they MUST be inlined,
> > so mark them as __always_inline.
> > 
> > Signed-off-by: Alberto Bertogli <albertito@xxxxxxxxxxxxxx>
> > ---
> >  include/linux/bio.h |    6 ++++--
> >  1 files changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/include/linux/bio.h b/include/linux/bio.h
> > index 0c8e3fb..713ec6e 100644
> > --- a/include/linux/bio.h
> > +++ b/include/linux/bio.h
> > @@ -445,7 +445,8 @@ extern struct biovec_slab bvec_slabs[BIOVEC_NR_POOLS] __read_mostly;
> >   *
> >   * This function MUST be inlined - it plays with the CPU interrupt flags.
> >   */
> > -static inline char *bvec_kmap_irq(struct bio_vec *bvec, unsigned long *flags)
> > +static __always_inline char *bvec_kmap_irq(struct bio_vec *bvec,
> > +		unsigned long *flags)
> 
> The comment is wrong - this was a sparc requirement, long since removed.

The comment probably dates back to around 2001 or so, I wasn't aware
that the non-local irq flags requirement had since been voided on sparc.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/