Re: [PATCH 1/2] usb-serial : fix the nousb oops

From: Dave Young
Date: Sun Feb 01 2009 - 20:43:23 EST


On Sun, Feb 1, 2009 at 11:51 PM, Greg KH <greg@xxxxxxxxx> wrote:
> On Sun, Feb 01, 2009 at 06:53:23PM +0800, Dave Young wrote:
>>
>> In case with "nousb" booting, serial drivers will trigger kernel oops.
>
> They will? What is the oops message?

Yes, they will, at lease I saw usb_serial/aircable/ftdi_sio oops. I
will manage to copy the oops message later.

>
>> Here add usb_disabled() check in usb_serial_init and usb_serial_register
>
> This is odd, is it something new? Why is usb-serial the only driver
> that needs such a thing?

No, it is not new thing. usb serial drivers normally call
usb_serial_register first, then usb_register, usb_register will fail
due to "nousb" checking, but usb_serial_register no.

>
> confused,
>
> greg k-h
>



--
Regards
dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/