Re: [git pull -tip] headers_check fixes for other architectures

From: Jaswinder Singh Rajput
Date: Sun Feb 01 2009 - 13:35:00 EST


On Sun, 2009-02-01 at 17:49 +0100, Ingo Molnar wrote:
> * Ingo Molnar <mingo@xxxxxxx> wrote:
>
> > > These patches fixes 41 headers_check warnings as shown in first email.
> >
> > Pulled into tip/core/header-fixes, thanks Jaswinder!
>
> These are the remaining ones on x86:
>
> 17 /dev/shm/tip/usr/include/linux/reiserfs_fs.h
> 12 /dev/shm/tip/usr/include/linux/soundcard.h
> 6 /dev/shm/tip/usr/include/asm/setup.h
> 3 /dev/shm/tip/usr/include/linux/nubus.h
> 2 /dev/shm/tip/usr/include/linux/in6.h
> 1 /dev/shm/tip/usr/include/mtd/jffs2-user.h
> 1 /dev/shm/tip/usr/include/linux/socket.h
> 1 /dev/shm/tip/usr/include/linux/coda_psdev.h
> 1 /dev/shm/tip/usr/include/asm/prctl.h
>
> They are all of the "extern's make no sense in userspace" type. What was the
> verdict, are they worth touching, or should we turn off this warning in
> 'make headers_check'?
>

I have the patches in queue which fixes above warnings except:

12 /dev/shm/tip/usr/include/linux/soundcard.h
1 /dev/shm/tip/usr/include/mtd/jffs2-user.h

Because these two files are using userspace functions.

--
JSR



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/