Re: checkpatch.pl is getting too slow

From: Andy Whitcroft
Date: Sat Jan 31 2009 - 16:02:49 EST


On Sat, Jan 31, 2009 at 10:55:07AM -0800, Greg KH wrote:
> Hi Andy,
>
> I've noticed that checkpatch.pl is getting slower and slower when run on
> a whole file, but yesterday I realized that it now is pretty much
> unusable:
>
> $ time ./scripts/checkpatch.pl --file drivers/staging/uc2322/aten2011.c
>
> <snip>
> total: 168 errors, 126 warnings, 3939 lines checked
>
> drivers/staging/uc2322/aten2011.c has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> real 8m7.924s
> user 8m7.058s
> sys 0m0.116s

That is scarey indeed. Something is very wrong in there if it went back
to a more reasonable 10's of seconds with a few patches. I will have a
look at the file you attached and see what I can find.

Thanks for the heads up.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/