Re: [PATCH] sched_rt: don't use first_cpu on cpumask created withcpumask_and.

From: Ingo Molnar
Date: Sat Jan 31 2009 - 08:50:14 EST



* Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:

> Ingo, please apply to tip/urgent.
>
> cpumask_and() only initializes nr_cpu_ids bits, so the (deprecated)
> first_cpu() might find one of those uninitialized bits if nr_cpu_ids
> is less than NR_CPUS (as it can be for CONFIG_CPUMASK_OFFSTACK).
>
> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> ---
> kernel/sched_rt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Applied to tip/sched/urgent, thanks Rusty!

Also, Git sorted out the same-content merge with this commit in cpus4096
just fine:

d38b223: cpumask: reduce stack usage in find_lowest_rq

(this commit is where you backported it from i suspect?)

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/