Re: [PATCH 1/4] kthreads: move sched-realeted initialization from kthreadd context

[Rusty Russell]

On Friday 30 January 2009 23:03:50 Oleg Nesterov wrote:
> (on top of kthread-dont-looking-for-a-task-in-create_kthread-2.patch)

Hi Oleg,

   Thanks for the cc: Vitaliy, I never saw that patch.  I've included it in my queue now.

As to this patch, it seems marginal.  I've never been convinced that we should
be trying to rescue root if they choose to set kthreadd's prio anyway, but I'm also wondering why we care about kthread_create scalability!

Still, I'm happy to apply it with one change:

> +		/*
> +		 * root may have changed our (kthreadd's) priority or CPU mask.
> +		 * The kernel thread should not inherit these properties.
> +		 */
> +		sched_setscheduler_nocheck(create.result, SCHED_NORMAL, &param);
> +		set_user_nice(create.result, KTHREAD_NICE_LEVEL);
> +		set_cpus_allowed_ptr(create.result, CPU_MASK_ALL_PTR);

cpu_all_mask is the non-deprecated replacement for CPU_MASK_ALL_PTR.

Thanks!
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/