Re: [PATCH] x86: push old stack address on irqstack for unwinder

[Ingo Molnar]

* H. Peter Anvin <hpa@xxxxxxxxx> wrote:

> Ingo Molnar wrote:
>>
>> Would be nice to have an #ifdef-less primitive for this - something like:
>>
>> 	pushq_frame %rbp
>>
>> and a matching:
>>
>> 	popq_frame %rbp
>>
>> for those cases that need it (this one doesnt as we dont pop out of the 
>> stack).
>>
>
> It certainly would if this isn't a singleton, which I think it could 
> possibly be?

yeah. This is pretty much the only non-restored frame we construct so 
indeed it would be a singleton. Perhaps the IST ones are such ones too.

> Otherwise it really should be a part of an entry/exit macro; this is 
> somewhat special in that it sets up a frame pointer as something other 
> than a normal entry/exit sequence.

Sure - your call really.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/