Re: [PATCH] x86/powernow: fix cpus_allowed brokage when acpi=off

[Ingo Molnar]

* Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:

> On Thursday 29 January 2009 15:26:28 Yinghai Lu wrote:
> > 
> > Impact: fix current->cpus_allowed overwriting.
> ...
> > caused by
> > | commit 2fdf66b491ac706657946442789ec644cc317e1a
> > | Author: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> > | Date:   Wed Dec 31 18:08:47 2008 -0800
> > |
> > |    cpumask: convert shared_cpu_map in acpi_processor* structs to cpumask_var_t
> 
> Hi Yinghai!
> 
>    Indeed; Mike, that contained a bad conversion of 
> arch/x86/kernel/cpu/cpufreq/powernow-k8.c.
> 
>    This patch reverts the bad change (this code should still be converted
> to work_on_cpu of course, but that's a bigger change).
> 
>    Yinghai, as far as I can tell your other fixes are independent (and
> were a problem before this commit, yes?).  Can you re-submit them on top
> of this patch (which is for Ingo, but against latest Linus).
> 
> Subject: cpumask: fix powernow-k8: partial revert of 2fdf66b491ac706657946442789ec644cc317e1a
> 
> Impact: fix powernow-k8 when acpi=off (or other error).
> 
> There was a spurious change introduced into powernow-k8 in this patch:
> the cause if that we try to "restore" the cpus_allowed we never saved.
> 
> See lkml "[PATCH] x86/powernow: fix cpus_allowed brokage when
> acpi=off" from Yinghai for the bug report.
> 
> Cc: Mike Travis <travis@xxxxxxx>
> Cc: Yinghai Lu <yinghai@xxxxxxxxxx>
> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>

applied to tip/x86/urgent, thanks guys!

Dave, is it fine if we send the fix to Linus via this route - or would you 
like to do it yourself?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/